feat: added an overload for the AddS3 extension method to take the IS…#2380
feat: added an overload for the AddS3 extension method to take the IS…#2380steveski wants to merge 1 commit intoXabaril:masterfrom
Conversation
|
@steveski please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
|
dotnet-policy-service agree [company="sole trader"]
----
If God hadn't intended us to have a 3 martini lunch, then why do you think he put all those olive trees in the holy land?
… On 7 Mar 2025, at 20:17, dotnet-policy-service[bot] ***@***.***> wrote:
dotnet-policy-service agree [company="{your company}"]
|
feat: added an overload for the AddS3 extension method to take the IServiceProvider
What this PR does / why we need it:
Other health checks pass the IServiceProvider into the action/func parameter. This change add that option. I was in a position in my own project where fetching values from my appsettings.json couldn't work easily. The S3 ServiceUrl, access and secret keys needed to passed as well on the options and the only option seemed to be to hard code. Given .NET's HealthCheckRegistration provides the IServiceProvider it made more sense to place the S3HealthCheck instantian in that delegate and pass the SP through to the caller. Adding as an overload prevents old clients from breaking.
Which issue(s) this PR fixes:
None, feature only.
Please reference the issue this PR will close: #[issue number]
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
As it's an overload, all existing calling code will continue working.
Please make sure you've completed the relevant tasks for this PR, out of the following list: